Skip to content

fix: Use random scopes on TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit#36945

Merged
rosstimothy merged 1 commit intomasterfrom
codingllama/globallimiter-flaky-again
Jan 19, 2024
Merged

fix: Use random scopes on TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit#36945
rosstimothy merged 1 commit intomasterfrom
codingllama/globallimiter-flaky-again

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

@codingllama codingllama commented Jan 19, 2024

Fixes failures on certain high count scenarios involving multiple tests.

For example:

go test ./lib/auth/webauthn ./lib/services/local \
  -run '^TestLoginFlow_BeginFinish$|^TestPasswordlessFlow_BeginAndFinish$|^TestIdentityService_WebauthnSessionDataCRUD$|^TestIdentityService_GlobalWebauthnSessionDataCRUD$|^TestIdentityService_UpsertGlobalWebauthnSessionData_maxLimit$' \
  -count 100

#36832

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jan 19, 2024
@codingllama codingllama requested a review from Joerger January 19, 2024 18:58
@codingllama codingllama mentioned this pull request Jan 19, 2024
Merged
@Joerger Joerger added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 19, 2024
@rosstimothy rosstimothy added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit 60035f5 Jan 19, 2024
@rosstimothy rosstimothy deleted the codingllama/globallimiter-flaky-again branch January 19, 2024 21:09
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Jan 19, 2024

@codingllama See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR
branch/v15 Create PR

This was referenced Jan 19, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 zmb3 approved these changes

@Joerger Joerger Joerger approved these changes

Assignees

No one assigned

Labels

no-changelog Indicates that a PR does not require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codingllama @zmb3 @Joerger @rosstimothy